Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to convert project from Project Manager #64927

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 26, 2022

Closes godotengine/godot-proposals#4801

This is rather bare-bones implementation. It just opens a new dialog with a warning and runs the converter in the background. But IMO it's still better than hiding this option behind CLI.

ezgif.com-gif-maker.mp4

@jgillich
Copy link
Contributor

Useful feature, but the initial dialog is confusing, it's not clear what the difference between "OK" and "Perform Full Project Conversion" is.

@qarmin
Copy link
Contributor

qarmin commented Aug 27, 2022

#64396 will add two optional arguments - maximum file size and maximum line length, so I think that would be add them also here to be able to easily configure converter.

Since progress is visible command line, maybe better is to run converter with headless argument to not show new Godot window.

@bend-n
Copy link
Contributor

bend-n commented Aug 30, 2022

What if there is a visual progress bar too?

@Calinou
Copy link
Member

Calinou commented Aug 30, 2022

What if there is a visual progress bar too?

Drawing the progress bar may be more trouble than it's worth, but I suppose the window title could be changed to indicate progress.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 12, 2022

I updated the first dialog:
image

@akien-mga akien-mga merged commit 78042ce into godotengine:master Sep 13, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to convert 3.x projects to 4.0 from Project Manager
6 participants