Decrease default AudioStreamPlayer2D/3D panning strength #64077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default panning strength is now more in line with how other engines play positional sound.
Calinou
force-pushed
the
tweak-audiostreamplayer2d3d-default-panning
branch
from
2261e17 to
160d10d
Compare
reduz
previously requested changes
Aug 14, 2022
| @@ -117,7 +117,7 @@ class AudioStreamPlayer3D : public Node3D { | |||
| float _get_attenuation_db(float p_distance) const; | |||
|
|
|||
| float panning_strength = 1.0f; | |||
| float cached_global_panning_strength = 1.0f; | |||
| float cached_global_panning_strength = 0.5f; | |||
There was a problem hiding this comment.
Does not seem like this is set anywhere?
There was a problem hiding this comment.
It's set here:
godot/scene/3d/audio_stream_player_3d.cpp
Line 916 in f2a6168
Likewise in 2D:
godot/scene/2d/audio_stream_player_2d.cpp
Line 475 in f2a6168
The value is set to the default in the header to avoid uninitialized data.
|
I don't see the need for the requested change if there are any, this would nice to have before stable... |
akien-mga
approved these changes
Nov 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default panning strength is now more in line with how other engines play positional sound.
This also improves documentation related to the audio panning strength project settings.
See #58841 where a test project is linked.