Add NavigationMesh baking for HeightMapShape3D #63932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
navigation_heightmapshape_baking_4.x
branch
from
8727b1d to
74b730c
Compare
smix8
force-pushed
the
navigation_heightmapshape_baking_4.x
branch
from
74b730c to
8b45dfa
Compare
Adds HeightMapShape for StaticColliders and GridMap to the NavigationMeshGenerator for baking NavigationMesh.
smix8
force-pushed
the
navigation_heightmapshape_baking_4.x
branch
from
8b45dfa to
5137cd9
Compare
akien-mga
approved these changes
Aug 8, 2022
|
Thanks! |
|
Just to note I didn't have time to properly look at this, but the only concern is the faces are duplicating vertices on each line, whereas they could be shared and use indices. I don't know whether duplicates are taken care of later on in the baking. I know that with a baked navigation mesh I was working with, there still appeared to be duplicate verts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HeightMapShape3D for StaticColliders and GridMap to the NavigationMeshGenerator for baking NavigationMesh.
Fixes #51289
I have a dedicated pr prepared for 3.x as names and function return values are different.