Fix find_children not searching recursively in some cases #63785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heppocogne
force-pushed
the
Fix-find_children-not-recursive
branch
from
5cc6d45 to
2756590
Compare
|
The fix itself makes sense, but we don't normally resort to |
|
Honestly, I don't want to use if (p_recursive) {
ret.append_array(cptr[i]->find_children(p_pattern, p_type, true, p_owned));
}
continue; |
Yes, or think about another way. |
kleonc
reviewed
Apr 17, 2023
Comment on lines
1419
to
1421
| if (p_owned && !cptr[i]->data.owner) { | ||
| continue; | ||
| goto next_loop; | ||
| } |
There was a problem hiding this comment.
Regarding this change I think the previous behavior might be intended, see #75459 (comment).
|
Superseded by #75459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #63757