Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor setting to make following links add to history in script editor #63682

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snailrhymer
Copy link
Contributor

@snailrhymer snailrhymer commented Jul 30, 2022

Implements (main proposal in) godotengine/godot-proposals#4462, and should be combinable with #63515 with not much effort.

Add editor setting to enable following links to add to history, even if the link lands on the same page. This effects both script editor and help tabs.

The addition of a "history save depth" should allow different saving behaviours to coexist, so more could be added as toggelable options. (History save depth also fixes #63681.)

…ditor

Split history saving into "update current" and "write new" stages so that changes to the same page can occur between these steps.

Add a "history save depth" to ensure actions that might save to history multiple times only do so once (e.g. opening a new help tab then moving to a section in that tab).

Add editor setting to enable following links to add to history, even if the link lands on the same page. This effects both script editor and help tabs.
@snailrhymer snailrhymer force-pushed the script-editor-history branch from dea042a to 52c2ca5 Compare July 30, 2022 16:55
@snailrhymer
Copy link
Contributor Author

Left as a draft in case other history saving triggers are desirable

@Calinou Calinou added this to the 4.0 milestone Jul 30, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 9, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.x Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Going to a method or property in editor help sometimes saves to history twice
3 participants