Disable polygon editing on foreign resources #63252
Open
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
force-pushed
the
disable_foreign_polygon_edits
branch
from
f820b77 to
2a852a4
Compare
SaracenOne
force-pushed
the
disable_foreign_polygon_edits
branch
from
2a852a4 to
56c65d9
Compare
|
Seeing the duplicate code here, I think there should be some method for checking whether a resource is foreign (either in Resource or EditorNode, or InspectorDock?). Something like |
|
Polygon editing should work as long as you re-create the polygon resource. If the resource was created locally, it will be saved without an issue. |
|
I think the trend should somehow be the same with this and the previous PR. If the subresource exists, wipe it before editing it and it should work. Revert icon should work fine too to get the original back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables polygon edits on foreign resources since the results will not be saved.