Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fields to VkRenderPassCreateInfo2KHR struct #63221

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Add missing fields to VkRenderPassCreateInfo2KHR struct #63221

merged 1 commit into from
Jul 20, 2022
+2 −0

Conversation

BastiaanOlij
Copy link
Contributor

Not all compilers clear structs resulting in unpredictable behavior (i.e. crashes), this PR clears 2 missing fields when calling vkCreateRenderPass2KHR when setting up our splash screen.

Should fix #63207

@BastiaanOlij BastiaanOlij added this to the 4.0 milestone Jul 20, 2022
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner July 20, 2022 02:55
@BastiaanOlij BastiaanOlij self-assigned this Jul 20, 2022
@BastiaanOlij BastiaanOlij mentioned this pull request Jul 20, 2022
Closed
@nathanfranke
Copy link
Contributor

Confirmed fixes #63207 😄

@BastiaanOlij BastiaanOlij requested a review from akien-mga July 20, 2022 03:44
@akien-mga akien-mga merged commit 7378dc6 into godotengine:master Jul 20, 2022
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_createinfo_struct branch July 20, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[4.x regression] segmentation fault at /usr/lib/amdvlkpro64.so
3 participants
@BastiaanOlij @nathanfranke @akien-mga