Don't process input in hidden EditorProperty. #63197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes EditorProperty nodes to intercept input events even when the Editor Properties dialog is not visible. This means that after closing the dialog, ctrl+shift+c will still copy the last selected property path. Fixes godotengine#62866.
|
Thanks! |
akien-mga
added
the
cherrypick:3.5
|
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes EditorProperty nodes to intercept input events even when the
Editor Properties dialog is not visible. This means that after closing
the dialog, ctrl+shift+c will still copy the last selected property
path.
Fixes #62866.
4.0 uses
shortcut_inputinstead ofunhandled_input, which does not have the same issue.shortcut_inputis not available in 3.x, so we have to work around it.