Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SceneTree dependency from LocalDebugger #62542

Merged

Conversation

TechnoPorg
Copy link
Contributor

Part of #53295 - core classes should not have dependencies on scene classes. Although, as of right now, this doesn't accomplish anything in practice, since Resource depends on Node, which depends on SceneTree.
This is probably overly cautious, since it's unlikely the MainLoop will be any type other than SceneTree, but it doesn't hurt to check.

Core classes should not have dependencies on scene classes.
@TechnoPorg TechnoPorg requested a review from a team as a code owner June 30, 2022 01:54
@akien-mga akien-mga added this to the 4.0 milestone Jun 30, 2022
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit 62994be into godotengine:master Jun 30, 2022
@akien-mga
Copy link
Member

Thanks!

@TechnoPorg TechnoPorg deleted the remove-scene-tree-dependency branch June 30, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants