Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integer animation tracks be continuous when created #62190

Closed

Conversation

YeldhamDev
Copy link
Member

No description provided.

@YeldhamDev YeldhamDev added this to the 4.0 milestone Jun 19, 2022
@YeldhamDev YeldhamDev requested a review from a team June 19, 2022 00:40
@YeldhamDev YeldhamDev force-pushed the ints_dont_need_discretion branch from becbf58 to b2eafce Compare June 19, 2022 00:42
@YeldhamDev YeldhamDev force-pushed the ints_dont_need_discretion branch from b2eafce to 5db7b37 Compare June 19, 2022 00:54
@fire fire requested a review from a team June 19, 2022 02:34
@fire fire requested a review from TokageItLab July 10, 2022 19:08
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think BASIS can be added.

Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, those cubic interpolation is done by Animation::_cubic_interpolate in animation.cpp, so that may need to be implement it.

@reduz
Copy link
Member

reduz commented Jul 11, 2022

I am not sure myself, a lot of things you can animate like states, frames, etc. are also integers. Those work fine now and it would break and be difficult to understand why. On the other hand if something is not continous its easy to understand why and fixing it. It just seems kind of odd to make integer tracks continuous by default. I would be happy if you can explain in which situations do you need this.

@reduz
Copy link
Member

reduz commented Jul 11, 2022

At much, we could make it dependant on the hint I think.

@KoBeWi
Copy link
Member

KoBeWi commented Jul 11, 2022

While I don't much get the reasoning either (although vaguely remember it being discussed), I tested it and it doesn't seem to break anything, e.g. frame animations are the same as before.

@reduz
Copy link
Member

reduz commented Jul 11, 2022

@KoBeWi I think what changes is that the value is sent all the time, and I am not entirely sure if this will work with every property or if every possible property checks that the value is different before doing what needs to be done. If it does check, it may add a hidden performance issue in many cases associated to a state change.

@YeldhamDev
Copy link
Member Author

I would be happy if you can explain in which situations do you need this.

The reason why I made this PR was because I was trying to animate the margins of a Control node, which are integer values. And believe me, it didn't immediately click to me that the reason everything was just directly snapping into place was because the track was set to discrete mode.

@YeldhamDev YeldhamDev force-pushed the ints_dont_need_discretion branch from 5db7b37 to 670331c Compare July 30, 2022 15:48
@YeldhamDev YeldhamDev force-pushed the ints_dont_need_discretion branch from 670331c to 0cca402 Compare July 30, 2022 15:52
@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Feb 9, 2023
@AThousandShips AThousandShips removed this from the 4.x milestone Jan 2, 2024
@YeldhamDev YeldhamDev deleted the ints_dont_need_discretion branch January 3, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants