-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make integer animation tracks be continuous when created #62190
Make integer animation tracks be continuous when created #62190
Conversation
becbf58
to
b2eafce
Compare
b2eafce
to
5db7b37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think BASIS can be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, those cubic interpolation is done by Animation::_cubic_interpolate
in animation.cpp
, so that may need to be implement it.
I am not sure myself, a lot of things you can animate like states, frames, etc. are also integers. Those work fine now and it would break and be difficult to understand why. On the other hand if something is not continous its easy to understand why and fixing it. It just seems kind of odd to make integer tracks continuous by default. I would be happy if you can explain in which situations do you need this. |
At much, we could make it dependant on the hint I think. |
While I don't much get the reasoning either (although vaguely remember it being discussed), I tested it and it doesn't seem to break anything, e.g. |
@KoBeWi I think what changes is that the value is sent all the time, and I am not entirely sure if this will work with every property or if every possible property checks that the value is different before doing what needs to be done. If it does check, it may add a hidden performance issue in many cases associated to a state change. |
The reason why I made this PR was because I was trying to animate the margins of a |
5db7b37
to
670331c
Compare
670331c
to
0cca402
Compare
No description provided.