Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting owner on internal nodes when save branch as scene #61966

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix setting owner on internal nodes when save branch as scene #61966

merged 1 commit into from
Jun 23, 2022

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Jun 12, 2022

Fix #54960.

Previously, setting owner was performed on all child nodes. Actually, it should not be performed on internal nodes.

@Rindbee Rindbee requested a review from a team as a code owner June 12, 2022 06:05
@Rindbee Rindbee changed the title Fix setting owner on internal nodes when save brach as scene Fix setting owner on internal nodes when save branch as scene Jun 12, 2022
@akien-mga akien-mga added this to the 4.0 milestone Jun 12, 2022
@akien-mga akien-mga requested a review from KoBeWi June 15, 2022 06:03
KoBeWi
KoBeWi approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: the regression comes from before #30391, but that PR made it possible to fix (it wouldn't be that simple without internal nodes).

@akien-mga akien-mga merged commit 91b984a into godotengine:master Jun 23, 2022
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the fix-internal-nodes-owned branch June 23, 2022 12:56
This was referenced Oct 4, 2023
Closed
Merged
@KoBeWi KoBeWi mentioned this pull request Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

ScrollContainer internal ScrollBars exposed when saved as a separate scene
3 participants
@Rindbee @akien-mga @KoBeWi