Add a shadow opacity property to Light3D #61893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
light3d-add-shadow-opacity
branch
2 times, most recently
from
3b67f19 to
63f1805
Compare
|
I fixed shadow fade, it now works (tested with both OmniLight3D and SpotLight3D). |
reduz
previously requested changes
Aug 6, 2022
servers/rendering/renderer_rd/shaders/scene_forward_lights_inc.glsl
Outdated
Show resolved
Hide resolved
|
Seems ok save for the comment I made. Needs rebase. |
This can be used to make shadows translucent for a specific light. The light distance fade system also uses this to smoothly fade the shadow when the light fade transition distance is greater than 0.
Calinou
force-pushed
the
light3d-add-shadow-opacity
branch
from
63f1805 to
baaa750
Compare
|
Rebased (with suggestion applied) and tested again, it works as expected on all light types. |
akien-mga
approved these changes
Aug 7, 2022
|
Thanks! |
This was referenced Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to make shadows translucent for a specific light. Performance seems to be identical from before, both with shadows enabled and disabled. This is a partial reimplementation of the
shadow_colorproperty, which had to be removed for optimization reasons.The light distance fade system also uses this to smoothly fade the shadow when the light fade transition distance is greater than 0.