-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugin name in is_plugin_enabled
#61820
Allow plugin name in is_plugin_enabled
#61820
Conversation
There's also IMO, it would be better if only the plugin name was supported (i.e. like the docs), the fully qualified path is not a useful format for this API. Which means that #43734 should be reworked to make sure that it doesn't regress for the case it implemented. |
I've changed the other method as well ;) For now, both support path and name. Let me know if I should change it to name only, or change the docs :) I'm traveling now, but next week I'll have more time to take a look at #43734 to see if I've missed something ;) |
e6fcb78
to
725eb62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine to fix the regression for now but I think this still needs more work, it's a super weird API that requires passing a fully qualified path to the plugin.cfg
, and the docs are not reflecting this well.
Thanks! |
Indeed, the issue doesn't happen in 3.5. I incorrectly assumed that it's relevant for this version, because I forgot it was fixed .-. |
Fixes #61604.