Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the default idle parse delay in the script editor #61814

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 8, 2022

This makes errors reported 0.5 seconds faster compared to the previous default value, and is closer to other code editors' behavior such as VS Code.

In 4.0, the script editor can now report multiple errors and still has working autocompletion when there's at least one error, so this is probably less annoying than it would be in 3.x. Therefore, I recommend not cherry-picking this to 3.x (at least for now).

See godotengine/godot-proposals#4625.

@Calinou Calinou added this to the 4.0 milestone Jun 8, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 9, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM makes sense

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Could you rebase, as the commit is pretty old so it might be a pain to land on during bisects.

This makes errors reported 0.5 seconds faster compared to the previous
default value, and is closer to other code editors' behavior such as
VS Code.
@Calinou Calinou force-pushed the script-editor-decrease-idle-parse-delay branch from bfdef38 to cf09cc2 Compare June 21, 2024 22:40
@akien-mga akien-mga merged commit 8f03797 into godotengine:master Jun 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the script-editor-decrease-idle-parse-delay branch June 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants