Ensure Android Java and Kotlin compile to the same version #61579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
requested changes
May 31, 2022
Comment on lines
-2
to
-3
| apply from: 'config.gradle' | ||
|
|
There was a problem hiding this comment.
This is needed when doing gradle builds in the Godot Editor since in that environment, the app/build.gradle is the root gradle build file.
There was a problem hiding this comment.
I've updated the PR to include apply from: 'config.gradle' below the plugins DSL block (it can't go above).
To get everything to work properly using the plugins DSL, I also needed to update the settings.gradle file for plugin management to enable code based version selection.
I've now tested both the Editor custom build export, and an Android Studio build of the editor to confirm everything works.
madmiraal
force-pushed
the
android-kotlin-java-version
branch
from
333f95b to
fd2a9b0
Compare
m4gr3d
approved these changes
Jun 1, 2022
madmiraal
force-pushed
the
android-kotlin-java-version
branch
from
fd2a9b0 to
b19bbad
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a mismatch between the Java and Kotlin classes compilation version targets. Java classes are being compiled using Java version 11, but the Kotlin classes are being compiled to be compatible with Java version 1.8.
This is the warning generated by the Gradle build:
This PR ensures that Java and Kotlin classes are compiled to the same Java version: 11.