Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to improve the Project Manager display at small sizes #61215

Merged
merged 1 commit into from
May 20, 2022

Conversation

aaronfranke
Copy link
Member

  • Change the minimum size of the About dialog to allow it to shrink to a smaller but still usable size.
  • Change the names of the tabs to either verbose names or shorter names depending on the window size.
  • Change the column count of the Asset Library GridContainer depending on the window size.
  • Enable text clipping on the OptionButtons in the Asset Library tab to allow this menu to shrink down farther.

This PR would make sense to merge before #61211. With both of these PRs combined, we can get down to about 520px wide before things start clipping, and it's not trivial to make the Asset Library tab shrink more than that.

@Calinou
Copy link
Member

Calinou commented May 20, 2022

Preview with the minimum size ignored for demonstration purposes:

simplescreenrecorder-2022-05-20_14.33.11.mp4
simplescreenrecorder-2022-05-20_14.35.33.mp4

Tip: To ignore Godot's minimum window size without recompiling using KWin, press Alt + F3 then choose More Actions > Configure Special Application Settings…:

image

Then use Add Property… in the bottom-left corner of the dialog and search for Minimum Size. You may have to do this twice due to a KWin bug.

@akien-mga
Copy link
Member

Looks pretty good. Maybe we could also shorten (or simply hide) the version label when the window is too small to avoid the overlap (though I guess it doesn't happen when the minsize is respected, but maybe it can make it possible to reduce the minsize further?).

@akien-mga akien-mga merged commit c95c9ab into godotengine:master May 20, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 20, 2022
@Calinou
Copy link
Member

Calinou commented May 20, 2022

Maybe we could also shorten (or simply hide) the version label when the window is too small to avoid the overlap (though I guess it doesn't happen when the minsize is respected, but maybe it can make it possible to reduce the minsize further?).

Indeed, this is worth looking into to further improve display on Android. I would shorten the label to still display major.minor.patch at least, but the build identifier and commit hash can be hidden.

To save a bit of space on the full version label, we could drop the v prefix too.

@aaronfranke aaronfranke deleted the pm-size-tweaks branch May 20, 2022 16:17
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 22, 2022
akien-mga added a commit to akien-mga/godot that referenced this pull request May 25, 2022
akien-mga added a commit that referenced this pull request May 25, 2022
Riordan-DC pushed a commit to Riordan-DC/godot that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants