Tweak minsize of editor ColorPickerButtons #61133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-forge
suggested changes
May 18, 2022
There was a problem hiding this comment.
It needs to take editor scale (EDSCALE) into account. To do that, it might be better to store ColorPickerButton min size in the editor theme. It can be stored as a theme constant, and usages of EditorNode::COLOR_PICKER_BUTTON_SIZE can be replaced with Size2(0, get_theme_constant(SNAME("color_picker_button_height"), SNAME("Editor"))
|
Changed to theme constant. |
fire-forge
approved these changes
May 19, 2022
akien-mga
approved these changes
May 19, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #60867
I set the size to twice the default font size and it looks the same as before:
On bigger editor font sizes the buttons automatically adjust, on smaller sizes they are bigger than text.