ProjectSettings: use RBMap again instead of HashMap #61110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be worth adding a comment to make explicit why RBMap needs to be used for those. |
This fixes corruption of project.godot and failure to load global classes.
rburing
force-pushed
the
project_settings_use_rbmap
branch
from
79fe287 to
9d9b508
Compare
|
Done. |
akien-mga
approved these changes
May 17, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes corruption of
project.godotand failure to load global classes introduced by #60999.Fixes #61084
(The minimal reproduction project there has a corrupted
project.godot, which can be fixed by moving the_global_script_classesand_global_script_class_iconsup, outside of the[application]section.)