Fix Curve2D/Curve3D baking #61090
Merged
Fix Curve2D/Curve3D baking #61090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 16, 2022
akien-mga
reviewed
May 16, 2022
| @@ -1668,7 +1668,7 @@ PackedVector3Array Curve3D::tessellate(int p_max_stages, real_t p_tolerance) con | |||
| if (points.size() == 0) { | |||
| return tess; | |||
| } | |||
| Vector<HashMap<real_t, Vector3>> midpoints; | |||
| Vector<RBMap<real_t, Vector3>> midpoints; | |||
There was a problem hiding this comment.
Maybe add a comment to clarify that sorting is needed?
There was a problem hiding this comment.
That's a good idea. Added the following:
// The current implementation requires a sorted map.
Geometror
force-pushed
the
fix-curve-baking
branch
from
811cb03 to
bf9a836
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61086.
Looks like the midpoint map was expected to be sorted.
Regression from #60999.