Fix crash when editing pinned StyleBox #61071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
added
bug
topic:editor
crash
cherrypick:3.x
|
Memory a bit fuzzy, but by looking at code alone, I think you can just replace the check above with it. It was trying to do a similar thing but at a smaller scope. I'd also appreciate a short comment to explain the exclusion (e.g. "Avoid itself, stylebox can be shared between items"). |
timothyqiu
force-pushed
the
leading-stylebox
branch
from
6cb9aa3 to
4b013a9
Compare
YuriSizov
approved these changes
May 16, 2022
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61053
Other theme items may be reusing the leading/pinned StyleBox. Don't propagate changes into itself.