Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backspace when selection reaches left edge #60890

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix backspace when selection reaches left edge #60890

merged 1 commit into from
May 9, 2022

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented May 8, 2022

Fixes #60866.

@pfertyk pfertyk requested a review from a team as a code owner May 8, 2022 16:49
@KoBeWi KoBeWi added this to the 4.0 milestone May 8, 2022
@Paulb23
Copy link
Member

Paulb23 commented May 8, 2022

Any chance you could add a test for this usecase?

@pfertyk pfertyk force-pushed the issue-60866-fix-backspace-selection-left branch from 87ecb1c to 86302fe Compare May 9, 2022 11:56
@pfertyk pfertyk requested a review from a team as a code owner May 9, 2022 11:56
@pfertyk
Copy link
Contributor Author

pfertyk commented May 9, 2022

Excellent idea @Paulb23 , I forgot about that! :D Test added, I've also fixed a typo in test variable and one translation ;)

@KoBeWi
Copy link
Member

KoBeWi commented May 9, 2022

.po files shouldn't be edited directly. Weblate is used for that.

@pfertyk pfertyk force-pushed the issue-60866-fix-backspace-selection-left branch from 86302fe to d1aed90 Compare May 9, 2022 12:16
@pfertyk
Copy link
Contributor Author

pfertyk commented May 9, 2022

@KoBeWi I've removed the translation change. I'll register in Weblate later, to fix this ;)

@pfertyk
Copy link
Contributor Author

pfertyk commented May 9, 2022

Quick question: is there an approval process for translations? I've changed singal to signal in Weblate and it seems that the change is now in effect, without any extra steps ...

@akien-mga
Copy link
Member

Quick question: is there an approval process for translations? I've changed singal to signal in Weblate and it seems that the change is now in effect, without any extra steps ...

There's no approval process, it's all trust and peer review based. Has its limits but for now it's mostly been working OK.

@akien-mga akien-mga merged commit 5013c1d into godotengine:master May 9, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Backspace doesn't delete selection if selected beyond TextEdit
4 participants
@pfertyk @Paulb23 @KoBeWi @akien-mga