-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hint_albedo
, hint_white/black
in shaders
#60803
Conversation
3254042
to
9f959dd
Compare
Although not mentioned in the comment, the plan was also to replace |
@clayjohn |
They should both be renamed to |
9f959dd
to
3d66021
Compare
@clayjohn Done. Check if you want. |
3d66021
to
a8bbe57
Compare
Thanks! |
The replacement for Hint is overwritten here: https://github.com/Chaosus/godot/blob/a8bbe570caadd0161a8db9c980296b111042a6b8/servers/rendering/shader_language.cpp#L8235-L8262 |
@GiantBlargg Thanks for the notice - but next time create a new issue instead of posting to the closed PR. This should be fixed by #61554 |
Approved changes from PR meeting (godotengine/godot-proposals#2323 (comment)):
Closes godotengine/godot-proposals#2323