Cache script icons in editor #60789
Merged
Cache script icons in editor #60789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
enhancement
topic:editor
usability
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60127
This ensures that each script is parsed only once in search of the icon when updating scene tree. It makes loading scenes and especially editing much faster. It introduces a small issue that when you change script icon, it won't properly refresh until cache is cleared (right now it's cleared when any scene is closed). But this is a very minor issue compared to what this fixes.
I originally made this PR for 3.x branch, I couldn't reproduce the issue in master, as I don't have a "complex" enough 4.0 project. But I at least tested that it doesn't break anything.
Here's the original 3.x patch for easier cherry-picking: 0001-Cache-script-icons-in-editor.patch.txt