[dotnet6 branch] Move runtime_interop P/Invoke to function pointers #59588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
force-pushed
the
dotnet6-runtime-interop
branch
4 times, most recently
from
3c2062f to
7547107
Compare
|
Cause compiling problem in Windows (MSVC) as discussed. |
|
@GeorgeS2019 I'm aware of this. This PR intends to solve a different problem. I didn't want to fix the warnings in this one because it was getting big enough already as it is. |
|
@raulsntos A quick feedback, I tried introduced the changes and it builds without problem for Windows MSVC. |
raulsntos
force-pushed
the
dotnet6-runtime-interop
branch
3 times, most recently
from
d462e01 to
acb6837
Compare
- Moves runtime_interop methods to UnmanagedCallbacks struct that contains the methods as function pointers and is passed to C#. - Implements UnmanagedCallbacksGenerator, a C# source generator that generates the UnmanagedCallbacks struct in C# and the body for the NativeFuncs methods (their implementation just calls the function pointer in the UnmanagedCallbacks).
raulsntos
force-pushed
the
dotnet6-runtime-interop
branch
from
acb6837 to
eecd262
Compare
raulsntos
force-pushed
the
dotnet6-runtime-interop
branch
from
eecd262 to
f798ebd
Compare
|
Superseded by #64089 (I cherry-picked your changes there with some modifications) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of moving to function pointers is being able to call these methods when Godot is compiled with
target=release_debug.For convenience these are the files output by the source generator:
Godot.SourceGenerators.UnmanagedCallbacksGenerator.zip
TODO:
GodotTools.Internals.Internal. I guess we'll want to use the source generator there too.Methods that have a parameter of typeThese methods are now generated using by-ref parameters or copying to the stack so no need to convert to pointer.DebuggingUtils.godot_stack_info_vectorcan't be generated because it's not one of the GodotInteropStructs and it's aref structso I can't use Unsafe or CustomUnsafe to get the pointer.Godot.SourceGeneratorsproject for theGodotSharpassembly since we only want to run this generator and not the others but I should probably move this generator to the originalGodot.SourceGeneratorsassembly. Alternatively we can have separate source generators projects forGodotSharpand for user projects that could share common code with a shared library.outparameters are assigneddefault, otherwise the compiler complains that they are not assigned before leaving the method. Can we really avoid this?