-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directly compress mip maps from Basis Universal #59540
Conversation
c1310fd
to
5ec9aff
Compare
5ec9aff
to
8916a04
Compare
8916a04
to
2b7a458
Compare
2b7a458
to
4490b42
Compare
a8c90de
to
833450d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only gave it a very cursory check, would need in-depth review by @reduz. But the changes seem sensible, if BU can now support mipmaps properly we should use it.
3278f59
to
e1d9701
Compare
@lyuma since you worked on the mipmaps code, can you review that area? |
3481ad9
to
12d2e35
Compare
12d2e35
to
ef8f594
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ef8f594
to
a481d27
Compare
tl;dr This pr does three things.
|
Enable compressed mip maps from Basis Universal for faster compressions. Increase the quality to avoid corruption. To keep compatibility use the first mip of the previous internal Godot format.
a481d27
to
053174c
Compare
Superseded by: #62499 |
Part of: godotengine/godot-proposals#4271
Discussed with @reduz:
Only support basisu with uastc.
It has been veto'd to not include all possible platforms at the same time. Do not store all of etc2, dxt5, bptc at the same time due to excess file size.
To increase efficiency enable compressed mip maps from Basis Universal.
To improve quality enable UASTC RDO compression.
To keep compatibility use the first mip of the previous internal Godot format.
This does a trick where I use only the first image from now on to read its mipmaps.
Part of the V-Sekai group. https://github.com/v-sekai