Fixed Variant::zero() to explicitly return a value of zero
#59490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
fix-variant-zero
branch
from
ad53274 to
7fcd8de
Compare
This was referenced Mar 24, 2022
|
Superseded by #60093. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #57675.
Fixed #59474.
It must explicitly return a value of zero for
Variant::blend(). However, since Quaternion will does slerp without expmap inVariant::blend(), so the value of w must be 1.Another solution would be to implement a function that performs subtraction, such as
Variant::sub(), but that would be a bit exaggerated.