Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more occurrences of "stex" #58965

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

TechnoPorg
Copy link
Contributor

A couple of places were missed when renaming StreamTexture to CompressedTexture. It's entirely possible that there are still places which I've missed, containing the old name.

@fire
Copy link
Member

fire commented Mar 10, 2022

Did you get the class renames too?

Ref<CompressedCubemapArray> s;
s.instantiate();
st = s;
Ref<CompressedTextureLayered> ct;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed some st's below so it doesn't compile.

@akien-mga
Copy link
Member

The StreamTexture.svg icon should likely be renamed to CompressedTexture2D.svg, currently I don't think anything would use it if it doesn't have 2D in the name. It's supposed to be the icon for that specific type.

@TechnoPorg TechnoPorg force-pushed the remove-stex-occurrences branch from d950453 to f4bc9f5 Compare March 11, 2022 01:33
@akien-mga akien-mga merged commit af9a60d into godotengine:master Mar 11, 2022
@akien-mga
Copy link
Member

Thanks!

@TechnoPorg TechnoPorg deleted the remove-stex-occurrences branch March 13, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants