-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #52647 (Don't update CSG Shape when not inside tree) #58958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
@hoontee @timothyqiu I need some advice to decide what to do for So we're left with a regression in |
@akien-mga Ideally we would want to cherry-pick #58938 for its numerous fixes, however if that can't happen, I don't believe this one should be cherry-picked. The error in #52642 slows down the editor when there are several Paths. Of course, not seeing any CSGShapes in other scenes sucks too, so if it's decided that CSGPolygon paths are too rare then maybe you should cherry-pick this. Hard to make a call. |
@akien-mga #52642 is mostly annoyance I think. Cherry-picking this revert brings correctness. |
Cherry-picked for 3.4.4. |
Reverts #52647.
Fixes #54445.
#52642 stays fixed, presumably due to #40814.