-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize TabContainer tabs in editor #58749
base: master
Are you sure you want to change the base?
Conversation
3e8db56
to
a658094
Compare
Rebased. The issue with rearranging still exists, but it's better than nothing. |
Rebased and updated using PropertyListHelper. Seems to be working correctly now. |
Deleting / removing a child and undoing it does not restore the tab data. I'm not sure if we can fix this with the current undo system. Setting a child to/from top level does not remove/add the entry until the scene is reloaded. The notify_property_list_changed(); should probably be in sort children instead of add/remove/move notify. For some reason, the default value for the title seems to be the first child's name, not the child at a given index. In the screenshot, the second child's name is 'a2' but the title for tab1 is overridden to be set that from a default of 'a1'. |
Yeah so this is the result of the hack I used. I can fix it, but I'd rather wait until #88306 is merged and do it properly. |
I fixed the naming issue.
Changing |
a914e07
to
f159e0b
Compare
Closes godotengine/godot-proposals#592
Closes #26194