Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent checking of global uniform type outside the editor #57207

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Prevent checking of global uniform type outside the editor #57207

merged 1 commit into from
Jan 25, 2022

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jan 25, 2022

Fix #57200, I didn't touch the RenderingServer, just a corner case that cause this bug.

@Chaosus Chaosus requested a review from a team as a code owner January 25, 2022 16:26
@Chaosus Chaosus added this to the 4.0 milestone Jan 25, 2022
clayjohn
clayjohn approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Chaosus Chaosus merged commit b82cb79 into godotengine:master Jan 25, 2022
@Chaosus Chaosus deleted the fix_global_uniforms branch January 25, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Global shader uniforms do not work
2 participants
@Chaosus @clayjohn