Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the SnapGrid editor icon #56752

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jan 13, 2022

Make the icon more grid-like and snap to the 16x16 grid.

Closes godotengine/godot-proposals#819

100% Scale
ksnip_20220113-231409

200% Scale
ksnip_20220113-232828

Previous Version

100% Scale
x1

200% Scale
x2

For 3.x cherry-pick: SnapGrid.svgicon_snap_grid.svg.

@timothyqiu timothyqiu added enhancement topic:editor cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 13, 2022
@timothyqiu timothyqiu added this to the 4.0 milestone Jan 13, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner January 13, 2022 14:46
@YeldhamDev
Copy link
Member

Looks way too noisy for such a small icon.

@timothyqiu
Copy link
Member Author

Here's an alternate version:

ksnip_20220113-225554

In order to stick with the 16x16 grid, there's not much thickness choices...

@akien-mga
Copy link
Member

akien-mga commented Jan 13, 2022

How about keeping 3 lines/3 columns with width 1, and just make the grid 15x15 in the top-left corner? So there's one empty line on the right and bottom sides, and the bottom right corner of the magnet touches the bottom right corner.

Like this:
image

And the magnet as overlay in the bottom right corner, removing the bits of grid that touch the magnet as you did in the current icon.

@timothyqiu
Copy link
Member Author

timothyqiu commented Jan 13, 2022

Thanks for the suggestion :) I think it looks better now, two small variants:

With center pixel connected:

ksnip_20220113-231409

ksnip_20220113-232828

With center pixel disconnected:

ksnip_20220113-231726

ksnip_20220113-232713

@YeldhamDev
Copy link
Member

YeldhamDev commented Jan 13, 2022

Much better. I personally prefer the latter version. Nevermind, I think the connected version is better.

@timothyqiu
Copy link
Member Author

Updated the 200% scale version for easy comparison.

@akien-mga
Copy link
Member

I'd go with the connected version, looks great IMO.

@akien-mga akien-mga merged commit ce6de71 into godotengine:master Jan 14, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the snap-grid-icon branch January 14, 2022 16:44
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak GridSnap editor icon to not look like an abbreviation for "Antialiasing" in Chinese
3 participants