Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore console window output for editor app on Windows #55316

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Nov 25, 2021

Fix #54684 by preventing setting CREATE_NO_WINDOW on non-release (debug or editor) builds.

@Chaosus Chaosus requested a review from a team as a code owner November 25, 2021 18:56
@Chaosus Chaosus added this to the 4.0 milestone Nov 25, 2021
@Chaosus Chaosus force-pushed the win32_restore_console_window branch from 77c1310 to ed42445 Compare November 25, 2021 19:04
@Chaosus Chaosus force-pushed the win32_restore_console_window branch from ed42445 to 675111e Compare November 25, 2021 19:06
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. On my local builds I removed CREATE_NO_WINDOW entirely and it has not been a problem.

Perhaps @mhilbrunner should take a look too.

@akien-mga akien-mga requested a review from bruvzg November 25, 2021 21:51
@mhilbrunner
Copy link
Member

mhilbrunner commented Nov 25, 2021

This will work to fix the issue (that was introduced in #54591) for now.
I want to improve some things in that code, but its better than the current state, so IMO we should merge.

This will re-introduce the original issue (albeit only in Editor/Debug mode) that os.execute() does spawn a brief console window. Less annoying than the current state of not getting any console output.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK, but it probably gonna popup unnecessary console windows for tools like adb or codesign started from the editor. It would be better to add argument to the functions to control it, instead of hard-coding.

@mhilbrunner
Copy link
Member

mhilbrunner commented Nov 25, 2021

Yeah, thats what I had in mind and in the works, but I can easily rebase that on top of this, and having this fix in the mean time would be good. :)

@akien-mga akien-mga merged commit 2681d93 into godotengine:master Nov 25, 2021
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the win32_restore_console_window branch November 26, 2021 06:57
@ghost
Copy link

ghost commented Feb 4, 2022

Console is gone again from Windows builds after the recent Windows 11 Terminal fixes.

@Chaosus
Copy link
Member Author

Chaosus commented Feb 4, 2022

@filipworksdev Yes, this is intended and was introduced by @bruvzg in #56012, you can start from a console and the output will be redirected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console no longer showing in windows builds
5 participants