-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore console window output for editor app on Windows #55316
Restore console window output for editor app on Windows #55316
Conversation
77c1310
to
ed42445
Compare
ed42445
to
675111e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. On my local builds I removed CREATE_NO_WINDOW
entirely and it has not been a problem.
Perhaps @mhilbrunner should take a look too.
This will work to fix the issue (that was introduced in #54591) for now. This will re-introduce the original issue (albeit only in Editor/Debug mode) that os.execute() does spawn a brief console window. Less annoying than the current state of not getting any console output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK, but it probably gonna popup unnecessary console windows for tools like adb
or codesign
started from the editor. It would be better to add argument to the functions to control it, instead of hard-coding.
Yeah, thats what I had in mind and in the works, but I can easily rebase that on top of this, and having this fix in the mean time would be good. :) |
Thanks! |
Console is gone again from Windows builds after the recent Windows 11 Terminal fixes. |
@filipworksdev Yes, this is intended and was introduced by @bruvzg in #56012, you can start from a console and the output will be redirected. |
Fix #54684 by preventing setting CREATE_NO_WINDOW on non-release (debug or editor) builds.