Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the number of PulseAudio input channels when in verbose mode #54789

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 8, 2021

This is useful information to have for troubleshooting, and it's said to sidestep a possible race condition issue that breaks microphone recording on Linux.

Other verbose messages were tweaked to refer to output explicitly (as opposed to input).

See #33184.

This is useful information to have for troubleshooting, and it's
said to sidestep a possible race condition issue that breaks
microphone recording on Linux.
@Calinou Calinou requested a review from a team as a code owner November 8, 2021 23:45
@Calinou Calinou added this to the 4.0 milestone Nov 8, 2021
@Calinou Calinou added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Nov 8, 2021
@Calinou
Copy link
Member Author

Calinou commented Nov 9, 2021

@enorrmann @mgschwan To confirm whether this comment is still correct, can you test this editor build which is 3.4-stable with this PR cherry-picked on top? https://0x0.st/-5vV.zip

Try running the Mic Record demo with it, with and without Verbose Stdout enabled in the Project Settings.

Thanks in advance 🙂

@akien-mga akien-mga merged commit 03a70a9 into godotengine:master Nov 9, 2021
@akien-mga
Copy link
Member

Thanks!

@mgschwan
Copy link

mgschwan commented Nov 9, 2021

@enorrmann @mgschwan To confirm whether this comment is still correct, can you test this editor build which is 3.4-stable with this PR cherry-picked on top? https://0x0.st/-5vV.zip

I can confirm that the microphone does work with this version

@Calinou Calinou deleted the pulseaudio-print-input-channels branch November 9, 2021 11:05
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 15, 2021
@enorrmann
Copy link

Verbose Stdout

for me the issue remans, in part, the recording part works fine, but when I press Play, the app "hangs" for a couple of minutes, then it plays the sound, with lots of underruns
the log

@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants