Hide console window by default on Windows

[Calinou]

This prevents issues with text selection causing the editor to freeze indefinitely until said selection is aborted. This also matches Blender's behavior where the system console is hidden bydefault.

This also renames the setting to work in an affirmative manner ("show" instead of "hide").

Testing is welcome, as I haven't tested this on a proper Windows setup yet.

This closes #34200.

[starry-abyss]

I agree with hiding the console by default, but isn't the linked issue about when it's open, regardless of the default state?

[Calinou]

I agree with hiding the console by default, but isn't the linked issue about when it's open, regardless of the default state?

It is, but it becomes much less of a concern if you have to toggle the console manually. The original issue is a Windows limitation; we can't fix it without disabling text selection, which would prevent copy-pasting.

[starry-abyss]

This is kind of nitpicking, but why not just manually close the issue honestly saying "we won't fix this"? Why use this trick to pretend it's solved?

[Calinou]

This is kind of nitpicking, but why not just manually close the issue honestly saying "we won't fix this"? Why use this trick to pretend it's solved?

The original issue is still affecting users by default, which means it's far more likely to be encountered right now. By hiding the console by default, people won't encounter this issue nearly as often.

[mhilbrunner]

I somewhat agree with the comment that this doesn't fix that issue (although it reduces the impact).
So IMO we shouldn't close that issue because of this PR (whether we should close it as 'won't fix' is a seperate discussion that should happen in that issue IMO).

But having the console window hidden by default is a good idea for a number of reasons, IMO, so I like this PR. I'll try to test and review soon.

[akien-mga]

The issue can't be fixed, it's a Windows design choice. It's working as intended/not a bug. But our users experience it as a bug as it's crappy design, so a workaround is a proper fix (from Godot perspective) and the only one we can do.

Edit: I spoke too fast, see below.

[akien-mga]

Or well, maybe it can be fixed fully. The freeze happens due to the Windows 10+ "Quick Edit" feature of the console, which can apparently be disabled programmatically:
https://stackoverflow.com/questions/15750276/my-ui-hangs-when-i-select-some-area-in-the-console/15751433#15751433

[Calinou]

Or well, maybe it can be fixed fully. The freeze happens due to the Windows 10+ "Quick Edit" feature of the console, which can apparently be disabled programmatically: stackoverflow.com/questions/15750276/my-ui-hangs-when-i-select-some-area-in-the-console/15751433#15751433

Disabling quick edit apparently disallows text selection, which in turn disallows copy-pasting text from the console. This makes searching for errors online more difficult.

[akien-mga]

Well, bad_design++, but yeah that simply restores the pre-Windows 10 cmd.exe behavior where copying anything was almost impossible - you can still do it with right click, select all, and Ctrl-C twice IIRC.

But we could also expose this as an option, defaulting to disabling Quick Edit but with an easy way to re-enable it (it's just a SetConsoleMode call, like for showing/hiding the console).

[akien-mga]

Superseded by #56012.