Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bilinear TextureProgressBar with nine patch enabled #53792

Merged

Conversation

floppyhammer
Copy link
Contributor

Fix regression from #45815. When nine_patch_stretch is enabled, stretch margins in the progress direction being both zero result in division by zero.

Before:

image

After:

image

Should be cherry-picked for 3.x.

@floppyhammer floppyhammer requested a review from a team as a code owner October 14, 2021 03:26
@YeldhamDev YeldhamDev added bug regression topic:gui cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Oct 14, 2021
@YeldhamDev YeldhamDev added this to the 4.0 milestone Oct 14, 2021
@akien-mga akien-mga merged commit 569ea31 into godotengine:master Oct 14, 2021
@akien-mga
Copy link
Member

Thanks!

@floppyhammer floppyhammer deleted the fix-bilinear-texture-progress-bar branch October 14, 2021 09:01
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants