Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnimatableBody inherited from StaticBody for moving platforms #52286

Merged

Conversation

pouleyKetchoupp
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp commented Aug 31, 2021

Edit: changed name to AnimatableBody after discussion on the chat.

Another take on addressing godotengine/godot-proposals#2867, without renaming StaticBody.
Supersedes #51600.

Instead of having a physics node named Static that can be either Static or Kinematic, AnimatableBody is added again as a separate node:
-Inherited from StaticBody to make its usage clearer
-Gets sync to physics functionality from the old KinematicBody node.
-Still separated from CharacterBody to make its usage more focused (moving platforms and doors)

Properly implemented constant velocity for kinematic bodies in godot physics servers (induced velocity without actually moving). It's now possible to make animated platforms with conveyor belts.

Also updated description for the different physics nodes to make their usage clearer.

Here's how it looks in the node hierarchy now with the new icon:

And the nodes properties:

@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Aug 31, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team August 31, 2021 16:03
@pouleyKetchoupp pouleyKetchoupp requested review from a team as code owners August 31, 2021 16:03
@pouleyKetchoupp pouleyKetchoupp changed the title Add KinematicBody inherited from StaticBody for moving platforms Add AnimatableBody inherited from StaticBody for moving platforms Sep 1, 2021
Instead of having a physics node named Static that can be either Static
or Kinematic, AnimatableBody is added again as a separate node:
-Inherited from StaticBody to make its usage clearer
-Still separated from CharacterBody to make its usage more focused

Properly implemented constant velocity for kinematic bodies in godot
physics servers (induced velocity without actually moving).

Also updated description for the different physics nodes to make their
usage clearer.
@reduz reduz self-requested a review September 4, 2021 12:49
@pouleyKetchoupp pouleyKetchoupp merged commit a93fb26 into godotengine:master Sep 6, 2021
@pouleyKetchoupp pouleyKetchoupp deleted the restore-kinematic-body branch September 6, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants