Created an area-specific wind force that interacts with soft bodies #51751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffrey-cochran
commented
Aug 16, 2021
•
jeffrey-cochran
commented
- Fulfills proposal #2291
- Adds four parameters to the physics overrides of an Area3D that characterize a wind force, which interacts with all soft bodies intersecting the Area3D.
- Builds on the progress made in PR Updated softbody handling to allow for area/softbody collision detection and application of area gravity #50785
- Attached is a demo project: softbody_wind_force.zip
|
I'll squash this when I get to a computer |
pouleyKetchoupp
suggested changes
Aug 16, 2021
There was a problem hiding this comment.
Great job! It's almost there, I've left some suggestions to improve the code and editor usability. I haven't tested yet but I'll do it later today.
Edit: Also please check the failed automatic builds below, there are some errors to fix before this can be merged.
jeffrey-cochran
force-pushed
the
windforce
branch
4 times, most recently
from
61ef9ed to
8afd0c7
Compare
jeffrey-cochran
force-pushed
the
windforce
branch
3 times, most recently
from
0ec557c to
6c5c689
Compare
pouleyKetchoupp
suggested changes
Aug 17, 2021
jeffrey-cochran
force-pushed
the
windforce
branch
from
6c5c689 to
f426cb9
Compare
pouleyKetchoupp
suggested changes
Aug 19, 2021
jeffrey-cochran
force-pushed
the
windforce
branch
from
f426cb9 to
70d5c4f
Compare
jeffrey-cochran
force-pushed
the
windforce
branch
from
70d5c4f to
e806397
Compare
jeffrey-cochran
requested review from
pouleyKetchoupp
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.