Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct jitter in move and slide 2D #51742

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Correct jitter in move and slide 2D #51742

merged 1 commit into from
Aug 17, 2021

Conversation

fabriceci
Copy link
Contributor

I fixed a remaining jitter in the function and clean a bit of code.

Before (slowdown to see the jitter)
jitter

After
fixed

@fabriceci fabriceci requested a review from a team as a code owner August 16, 2021 16:00
@pouleyKetchoupp pouleyKetchoupp requested a review from a team August 16, 2021 16:17
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Aug 16, 2021
pouleyKetchoupp
pouleyKetchoupp approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and didn't spot any regression.

@TokageItLab
Copy link
Member

TokageItLab commented Aug 16, 2021 •
edited
Loading

Does this PR solve jittering on slope edge problem?

@fabriceci
Copy link
Contributor Author

fabriceci commented Aug 17, 2021 •
edited
Loading

@TokageItLab This was already fixed, this jitter is a new one.

@akien-mga akien-mga merged commit e60a155 into godotengine:master Aug 17, 2021
@akien-mga
Copy link
Member

Thanks!

@fabriceci fabriceci deleted the jitter-fix-and-cleaning branch August 17, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

Assignees
No one assigned
Labels
bug topic:physics topic:2d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriceci @TokageItLab @akien-mga @pouleyKetchoupp