-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editor setting for spin slider sensibility #50671
Add editor setting for spin slider sensibility #50671
Conversation
I think the setting should influence the speed of dragging both floating-point and integer values. |
it does already influence the integer values, as those are calculated based on this floating point value |
Needs an update. |
5993060
to
673fba4
Compare
Rebased on current master and adjusted to use Also I wasn't really able to test this in 4.x as dragging does not work for me (neither with or without this PR). |
673fba4
to
c497df2
Compare
Updated to work with current master. From my side this is ready now. |
87cd326
to
bccb383
Compare
a6be24f
to
81fda33
Compare
And now the CI should be happy too 🤞 |
81fda33
to
19b41f7
Compare
It crashes when generating the documentation, instantiating
|
9d9d59b
to
e54f4c3
Compare
e54f4c3
to
277e261
Compare
Thanks! |
This PR adds an editor setting "Float Drag Speed" to control the base speed of dragging EditorSpinSlider nodes. It is applied directly to
grabbing_spinner_dist_cache
which means that all the other logic (pressing shift to slow down; pressing control to snap to integers; and always being a multiple ofstep
) works flawlessly with the new speed. The initial value for the setting is5.0
to increase the base speed.Closes godotengine/godot-proposals/issues/3017
Probably also makes godotengine/godot-proposals/issues/2760 obsolete. That proposal requests a key to increase the drag speed. With this PR it would instead have an increased base speed, using the existing shift modifier to slow the speed down if needed. This is in line with other applications like blender that use a similar approach.