Optimize usage of Transform::xform and unit tests #50611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the xform functions, and introduces unsafe function versions for the old behaviour.
lawnjelly
force-pushed
the
fix_xform_usage
branch
from
8ba2eb4 to
eaef816
Compare
With the change to safer slower versions of the Transform::xform and xform_inv functions, this PR goes through the engine to make better use of fast versions of the functions so as not to reduce performance. Also adds some unit tests for Transform.
lawnjelly
force-pushed
the
fix_xform_usage
branch
from
eaef816 to
101157c
Compare
|
Closing this in favour of #50637 which is a more cut down approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change to safer slower versions of the Transform::xform and xform_inv functions, this PR goes through the engine to make better use of fast versions of the functions so as not to reduce performance.
Also adds some unit tests for Transform.
Notes