Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the 3D editor manipulation gizmo #50597

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Improve the 3D editor manipulation gizmo #50597

merged 1 commit into from
Jul 28, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 18, 2021 •
edited
Loading

  • Allow some tolerance when clicking the plane move/scale, even if the click is actually slightly outside the plane (similar to Blender).
  • Make the rotate manipulation circles visually thinner to be less distracting.
  • Make the hovered color less saturated to be more distinguishable from the non-hovered state.
    • Don't set brightness above 1.0 to prevent the gizmo from glowing when hovered.

Preview

improved-3d-editor-gizmo.mp4

@Calinou
Improve the 3D editor manipulation gizmo
6cfcbbb 
- Allow some tolerance when clicking the plane move/scale,
  even if the click is actually slightly outside the plane
  (similar to Blender).
- Make the rotate manipulation circles visually thinner to be
  less distracting.
- Make the hovered color less saturated to be more distinguishable
  from the non-hovered state.
  - Don't set brightness above 1.0 to prevent the gizmo from glowing
    when hovered.
@Calinou Calinou requested a review from a team as a code owner July 18, 2021 22:46
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:3d topic:editor usability labels Jul 18, 2021
@Calinou Calinou added this to the 4.0 milestone Jul 18, 2021
@fire
Copy link
Member

fire commented Jul 19, 2021

Will try it out and ask all my friends to also.

@SaracenOne
Copy link
Member

Seems good to me! Subtle but sensible improvements.

@Leroy-X
Copy link

Leroy-X commented Jul 23, 2021

As a blender user, I hope to be able to use GRS key to move, rotate, and zoom like in blender;
even press GX2 to move two units on the x axis. This is a very efficient method of operation.

@Calinou
Copy link
Member Author

Calinou commented Jul 23, 2021

As a blender user, I hope to be able to use GRS key to move, rotate, and zoom like in blender;
even press GX2 to move two units on the x axis. This is a very efficient method of operation.

See godotengine/godot-proposals#1215.

@akien-mga akien-mga merged commit 7f0a83c into godotengine:master Jul 28, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 28, 2021
@Calinou Calinou deleted the 3d-editor-improve-manipulation-gizmo branch August 3, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Calinou @fire @SaracenOne @Leroy-X @akien-mga