-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to load Android build sources from file. #50481
Added ability to load Android build sources from file. #50481
Conversation
* If not present, the dialog asks to load build sources from a file. * The export templates check now also verifies that build sources are installed and skips the template check. This makes Android development easier.
Will this extract the zip file and copy the templates into the android folder each time you export? Or will it only do so if the android folder isn't yet there? I can foresee people forgetting to clear out the android folder after they build a new custom build and not realize they export with the version that was there before. |
@BastiaanOlij this is more of an advanced use case when you use your own sources file. You can't unzip over existing directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks! |
Cherry-picked for 3.4. |
@m4gr3d This has been cherry-picked already :) |
So this doesn't seem to work so well UX wise, as the custom export templates manager is only shown when the official custom source template is not available. So it works well if you're using case FILE_INSTALL_ANDROID_SOURCE: {
if (p_confirmed) {
export_template_manager->install_android_template();
} else {
if (DirAccess::exists("res://android/build")) {
remove_android_build_template->popup_centered_minsize();
} else if (export_template_manager->can_install_android_template()) {
install_android_build_template->popup_centered_minsize();
} else {
custom_build_manage_templates->popup_centered_minsize();
}
}
} break; IMO |
This makes Android development easier.
Bugsquad edit: Fixes #36728.