[3.x] Allow reading shaders from .gdshader
files
#49983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading
.gdshader
files, which adds forwards compatibility with #47336.Shaders seem to be the same between 3.x and the current master (at least the code for simple ones hasn't changed), it's only the file extension that changed. Since only
.gdshader
can be read in 4.0, once that comes out, shader authors will likely use.gdshader
. If we allow 3.x to read these files, then these shaders can be easily used in 3.x without renaming the files. This will also make it easier for people to future-proof their projects for eventual conversion to Godot 4.0 (at the cost of the shaders not being able to be read in Godot 3.3.2 or lower). But for now I would still recommend users use.shader
(or.tres
).When saving, the default file extension is
.tres
(same as the current 3.x), and both.shader
and.gdshader
are options.