Remove unused shadow_color property from Light3D
#49447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
remove-shadow-color-property
branch
from
28cdb2e to
a26e225
Compare
|
For those wondering, it's possible to emulate colored shadows for any light type by using two light nodes: Parent node (with shadows, and with the inverted color of the desired shadow color)
Child node (without shadows, and with the desired shadow color)
Result
Testing project: test_light_colored_shadows.zip |
Calinou
force-pushed
the
remove-shadow-color-property
branch
from
a26e225 to
661b58a
Compare
This shadow color property was no longer effective since the shaders were optimized to improve occupancy.
Calinou
force-pushed
the
remove-shadow-color-property
branch
from
661b58a to
aea104d
Compare
clayjohn
approved these changes
Mar 8, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shadow color property was no longer effective since the shaders were optimized to improve occupancy. Note that this doesn't affect its Light2D counterpart which still supports per-light shadow colors.
It could technically be supported in the lightmapper (for fully baked lights), but I can't find any references to the per-light shadow color in the GPU lightmapper in
master.Note: Not cherry-pickable to the
3.xbranch as per-light shadow color is still functional there.