Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor icons for Occluder3D and OccluderInstance3D #49263

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Add editor icons for Occluder3D and OccluderInstance3D #49263

merged 1 commit into from
Jun 3, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 2, 2021 •
edited
Loading

This "eclipse" design was suggested by @pycbouh.

Preview

image

Old revision of this PR

image

@Calinou Calinou requested a review from a team as a code owner June 2, 2021 21:27
@Calinou Calinou added this to the 4.0 milestone Jun 2, 2021
@YeldhamDev
Copy link
Member

That looks like it would be a little too similar to the Node3D icon when smaller.

@YuriSizov
Copy link
Contributor

That looks like it would be a little too similar to the Node3D icon when smaller.

We can go for a different shape, I guess?

@Joakker
Copy link

Joakker commented Jun 2, 2021

Why not make it a square on the inside? It's more easily differentiated, and you still preserve the idea of the original

@GameDevLlama
Copy link
Contributor

another option would be to make the eclipse even more obvious
like so:
image

@Calinou Calinou force-pushed the add-occluder3d-editor-icons branch from e43efb8 to 8a26179 Compare June 2, 2021 22:54
@Calinou
Copy link
Member Author

Calinou commented Jun 2, 2021

another option would be to make the eclipse even more obvious
like so:

Done, thanks for the idea 🙂

The exact design is slightly different to make it more aligned to the pixel grid.

@GameDevLlama
Copy link
Contributor

@Calinou very good job! Looks crisp now :-)

@akien-mga akien-mga merged commit 16e6b53 into godotengine:master Jun 3, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Jun 23, 2021
Merged
@Calinou Calinou deleted the add-occluder3d-editor-icons branch August 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YeldhamDev YeldhamDev YeldhamDev approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Calinou @YeldhamDev @YuriSizov @Joakker @GameDevLlama @akien-mga