Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bold fonts in editor #49148

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Use bold fonts in editor #49148

merged 1 commit into from
Jun 2, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented May 27, 2021

  • Labels are now bold
  • Categories in trees are bold
  • Main editor buttons are bold
  • Fixed section folding arrows in inspector

image

@reduz reduz requested review from a team as code owners May 27, 2021 15:35
@YuriSizov
Copy link
Contributor

Labels are now bold

Wait, all labels are bold by default? I'm not sure about that.

@YuriSizov YuriSizov added this to the 4.0 milestone May 27, 2021
@reduz
Copy link
Member Author

reduz commented May 27, 2021

@pycbouh for the most part it looks good in the editor. There are so me cases where it might be good to adjust at some point, but I think its pretty good for now.

@reduz reduz force-pushed the use-bold-fonts branch from bb2b313 to ac1416f Compare May 27, 2021 21:56
@reduz reduz requested a review from a team as a code owner May 27, 2021 21:56
Calinou
Calinou previously requested changes May 29, 2021
View reviewed changes
editor/editor_inspector.cpp Outdated Show resolved Hide resolved
@Calinou Calinou mentioned this pull request May 29, 2021
Closed
@Calinou
Copy link
Member

Calinou commented May 29, 2021 •
edited
Loading

Note that this PR could be remade for the 3.x branch, since it doesn't break compatibility with existing projects. The per-TreeItem custom font feature can also be useful in other places in the editor (and possibly even in projects).

@reduz
Copy link
Member Author

reduz commented Jun 2, 2021

@Calinou to be honest I would leave 3.x alone at this point, let it conserve its visual identity so 4.0 differentiates as much as possible.

@reduz
Use bold fonts in editor
d95bc3f 
* Labels are now bold
* Categories in trees are bold
* Main editor buttons are bold
* Fixed section folding arrows in inspector
@reduz reduz force-pushed the use-bold-fonts branch from ac1416f to d95bc3f Compare June 2, 2021 15:48
@akien-mga akien-mga requested a review from Calinou June 2, 2021 15:48
@akien-mga akien-mga dismissed Calinou’s stale review June 2, 2021 16:40

Changes done.

@akien-mga akien-mga merged commit 4e52b84 into godotengine:master Jun 2, 2021
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus mentioned this pull request Jun 3, 2021
Closed
@Byteron
Copy link
Contributor

Byteron commented Jun 9, 2021 •
edited
Loading

In the Node tab there is still no bold sections.
image

@bruvzg bruvzg mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@reduz @YuriSizov @Calinou @akien-mga @Byteron