[3.x] Upgrade Embree to the latest official release. #48967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Embree v3.13.0 supports AARCH64, switch back to the official repo instead of using Embree-aarch64. `thirdparty/embree/patches/godot-changes.patch` should now contain an accurate diff of the changes done to the library. (cherry picked from commit 767e374)
akien-mga
added
bug
enhancement
topic:thirdparty
cherrypick:3.x
akien-mga
changed the title
|
I made a test build (classical only, and no UWP) for this PR to help validate the upgrade (and especially make sure that it works fine with MinGW builds on Windows): https://downloads.tuxfamily.org/godotengine/testing/3.4-beta-embree3.13.0/ I'd love to know from lightmap users that:
Note: It's a build based on the |
akien-mga
added
cherrypick:3.3
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Embree v3.13.0 supports AARCH64, switch back to the
official repo instead of using Embree-aarch64.
thirdparty/embree/patches/godot-changes.patchshould now containan accurate diff of the changes done to the library.
Backport of #48885, including a fix for #48822.