Make RootMotionView use ArrayMesh instead of ImmediateGeometry #48568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
regression
topic:3d
topic:rendering
topic:editor
and removed
topic:rendering
labels
|
If we reach an agreement on this PR, it may be worth opening a similar PR for the |
TokageItLab
force-pushed
the
adopt-rootmationview-to-arraymesh
branch
3 times, most recently
from
f6e6598 to
cae4981
Compare
TokageItLab
changed the title
TokageItLab
force-pushed
the
adopt-rootmationview-to-arraymesh
branch
2 times, most recently
from
62a1705 to
19d7597
Compare
TokageItLab
force-pushed
the
adopt-rootmationview-to-arraymesh
branch
from
19d7597 to
2f15c33
Compare
|
I think we need to wait and see how efficient ImmediateGeometry is in Vulkan before evaluating this PR. Recreating an ArrayMesh each frame will be an unnecessary bottleneck. Ideally ImmediateGeometry will be implemented in a way that is optimized for per-frame updates. |
|
Indeed. We are still waiting for the implementation of |
|
If changes to the original implementation are allowed, drawing the grid with the shader may be the most performant. |
|
fixed by #50014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #48389
2021-05-09.10.19.38-1.mov