-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_interface for access by GDNative #46781
Conversation
a6d13f6
to
c98eee2
Compare
Still crashing with:
For the reference, here's what that CI Linux build with sanitizers and test project does: godot/.github/workflows/linux_builds.yml Lines 188 to 210 in 6b48fce
|
Note before this gets lost and forgotten. After discussion on godot chat about this we've decided to do this more proper and add the required function to the ARVR GDNative API. Will find some time for that soonish. |
c98eee2
to
29c2647
Compare
Ok, so I redid this whole thing and just updated the opening text. Also added access to the depth buffer. |
- add set_interface function - add access to depth buffer - add supplying a depth buffer from an ARVR plugin
29c2647
to
717f322
Compare
Thanks! |
Ok, I've completely redone this and added a few additional changes to this.
We can now call the set_interface through a new GDNative ARVR API call.
As I'm adding a new API level I've also added another often requested feature and that is to get access to the depth buffer.
This is important in XR for re-projection during frame drops and to enable stuff like LIV (https://www.liv.tv/) and other mixed reality solutions.
I've also added an option to provide an external depth buffer alongside the external color buffer.
The depth buffer changes are pretty experimental especially on GLES2 as there is no way to switch between render buffer and texture.