Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect auto-indentation in multiline brackets (fix #46384) #46627

Conversation

jmb462
Copy link
Contributor

@jmb462 jmb462 commented Mar 3, 2021

Fix #46384

Closing bracket was not send at the correct indentation when a new line was added inside a pair of brackets.

Changed made in this PR :

In the function TextEdit::_new_line() : p_split_current_line boolean test was not correct (a true value couldn't pass the testing condition and p_split_current_line is true for a classic new line (ENTER).

brace_ident

@jmb462 jmb462 requested a review from a team as a code owner March 3, 2021 18:19
@YeldhamDev YeldhamDev added this to the 4.0 milestone Mar 3, 2021
@YeldhamDev YeldhamDev requested a review from a team March 3, 2021 18:22
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akien-mga akien-mga merged commit dc2207d into godotengine:master Mar 7, 2021
@akien-mga
Copy link
Member

Thanks!

@jmb462 jmb462 deleted the fix-incorrect-autoindentation-in-multiline-brackets branch March 7, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect indentation in multiline bracket auto-completion.
4 participants